Deprecated the old Material Design 2 theme to avoid using it#6815
Open
Deprecated the old Material Design 2 theme to avoid using it#6815
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Deprecates the legacy Compose Material Design 2 theme wrapper (HomeAssistantAppTheme) to discourage new usage during the ongoing migration to the Material Design 3-based HATheme.
Changes:
- Marked
HomeAssistantAppThemeas@Deprecatedwith guidance to useHAThemeinstead - Added an IDE auto-fix suggestion via
ReplaceWithto ease migration of call sites
Member
|
Not sure about the autofix suggestion - it is not a drop in replacement and you might end up with contributors mixing M2 with M3 components which is also undesirable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We are in the middle of migrating to Material Design 3, we kept the
HomeAssistantAppThemefor backward compatibility for screen that are not yet merged. This PR simply deprecates it so new contributors knows that we are migrating.